Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for CFFWIS - Reload modules #1284

Merged
merged 1 commit into from Jan 27, 2023
Merged

Add doc for CFFWIS - Reload modules #1284

merged 1 commit into from Jan 27, 2023

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • build_indicator_module_from_yaml now accepts a reload argument. When re-building a module that already exists, reload=True removes all previous indicator before creating the new ones. (:issue:1192,:pull:1284).
  • Add a remark about how xclim's CFFWIS is different from the original 1982 implementation. (:issue:1104, :pull:1284).

Does this PR introduce a breaking change?

No.

Other information:

@github-actions github-actions bot added the indicators Climate indices and indicators label Jan 27, 2023
Zeitsperre
Zeitsperre approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Approved for additional tests label Jan 27, 2023
@Zeitsperre
Copy link
Collaborator

@aulemahal feel free to merge. We can update the CI in another PR.

@aulemahal aulemahal merged commit 8e14de1 into master Jan 27, 2023
@aulemahal aulemahal deleted the fewfixes branch January 27, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests indicators Climate indices and indicators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reload modules when rebuilding with the same name Better document the FWI versions
2 participants
@aulemahal @Zeitsperre