Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to tox v4.0 and adjust local testing default configurations #1297

Merged
merged 8 commits into from Feb 24, 2023
Merged

Upgrade to tox v4.0 and adjust local testing default configurations #1297

merged 8 commits into from Feb 24, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Feb 14, 2023 •
edited

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Revises two environment variables (XCLIM_TESTDATA_BRANCH and XCLIM_PREFETCH_TESTING_DATA) to better limit their scope and clarify their purposes.
  • Upgrades tox configuration to use version 4.0 by default
  • Moves some configurations out of pyproject.toml to better facilitate local development
  • Removes several geojson files that are no longer used (previously used for subset tools).

Does this PR introduce a breaking change?

Yes. Environment variables and testing data have been modified.

Other information:

@Zeitsperre
implement XCLIM_TESTDATA_BRANCH and XCLIM_PREFETCH_TESTING_DATA e…
0f6eee3 
…nvironment variables, remove obsolete subset-specific testing data, adjust testing data fetching logic
@Zeitsperre
stage tox-conda for eventual integration
c7cfc8d
@Zeitsperre
upgrade to tox>=4.0, adjust tox configuration to set pytest-xdist and…
b69b867 
… coverage options as needed, adjust pyproject.toml to not use pytest-xdist/report coverage by default
@Zeitsperre Zeitsperre added standards / conventions Suggestions on ways forward information For development/intsructional purposes labels Feb 14, 2023
@Zeitsperre Zeitsperre added this to the v0.41 milestone Feb 14, 2023
@Zeitsperre Zeitsperre self-assigned this Feb 14, 2023
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Feb 14, 2023
huard
huard approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

HISTORY.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added the approved Approved for additional tests label Feb 23, 2023
@Zeitsperre Zeitsperre merged commit 2b5e23d into master Feb 24, 2023
@Zeitsperre Zeitsperre deleted the local_testing_adjustments branch February 24, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huard huard huard approved these changes

@aulemahal aulemahal Awaiting requested review from aulemahal

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests CI Automation and Contiunous Integration information For development/intsructional purposes standards / conventions Suggestions on ways forward
Projects
None yet
Milestone
v0.41
Development

Successfully merging this pull request may close these issues.

Streamline local and remote development testing with tox/ GitHub CI
2 participants
@Zeitsperre @huard