Fix mean radiant temperature segfaults #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, that was almost too easy... |
aulemahal
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
test_mean_radiant_temperaturesometimes fails with segfault #1303number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
test_mean_radiant_temperature()from causing segfaultsDoes this PR introduce a breaking change?
No.
Other information:
There is something thread-unsafe when making multiple calls to
atmos.mean_radiant_temperature. My theory is thatdaskis trying to read the exact same blocks of data in rapid succession, as the values between all calls are being compared at the same time. If we.load()this data, we don't trigger and this is fine, somehow.