Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings issued from successive convert_units_to calls #1319

Merged
merged 7 commits into from Mar 23, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Mar 13, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Fixes a bug in the logic of two indices (snowfall_approximation with method="brown", effective_growing_degree_days) that was emitting usage warnings from valid calls.
  • prepends v to entries in CHANGES.rst to properly generate hyperlink entries.
  • Warnings from set _version_deprecated within Indicators now emit FutureWarning instead of DeprecationWarning for greater visibility.

Does this PR introduce a breaking change?

No.

Other information:

See also: #1010

@Zeitsperre Zeitsperre added the bug Something isn't working label Mar 13, 2023
@Zeitsperre Zeitsperre added this to the v0.42 milestone Mar 13, 2023
@Zeitsperre Zeitsperre self-assigned this Mar 13, 2023
@github-actions github-actions bot added the indicators Climate indices and indicators label Mar 13, 2023
@github-actions github-actions bot added the approved Approved for additional tests label Mar 23, 2023
@Zeitsperre Zeitsperre merged commit 00bd949 into master Mar 23, 2023
13 checks passed
@Zeitsperre Zeitsperre deleted the fix_bad_calls branch March 23, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests bug Something isn't working indicators Climate indices and indicators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants