Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix last run resampling #1323

Merged
merged 18 commits into from Mar 30, 2023
Merged

Fix last run resampling #1323

merged 18 commits into from Mar 30, 2023

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Mar 15, 2023 •
edited

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • freq other than None now works with last_run

Does this PR introduce a breaking change?

No

Other information:

@Zeitsperre Zeitsperre added bug Something isn't working priority Immediate priority labels Mar 15, 2023
@Zeitsperre Zeitsperre added this to the v0.42 milestone Mar 15, 2023
coxipi
coxipi commented Mar 15, 2023
View reviewed changes
xclim/indices/run_length.py Outdated Show resolved Hide resolved
coxipi
coxipi commented Mar 15, 2023
View reviewed changes
xclim/indices/run_length.py Outdated Show resolved Hide resolved
Zeitsperre
Zeitsperre reviewed Mar 30, 2023
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
@coxipi @Zeitsperre
Better description CHANGES.rst
87aff92 
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre Zeitsperre marked this pull request as ready for review March 30, 2023 16:56
aulemahal
aulemahal approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I agree with the choice not to open the options for now. If the need comes up, we could reconsider it.

xclim/indices/run_length.py Show resolved Hide resolved
@github-actions github-actions bot added the approved Approved for additional tests label Mar 30, 2023
@coxipi coxipi merged commit 7f2dda2 into master Mar 30, 2023
13 checks passed
@coxipi coxipi deleted the fix_last_run_resampling branch March 30, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre left review comments

@aulemahal aulemahal aulemahal approved these changes

Assignees

@coxipi coxipi

Labels
approved Approved for additional tests bug Something isn't working priority Immediate priority
Projects
None yet
Milestone
v0.42
Development

Successfully merging this pull request may close these issues.

Run length & resample not working for last_run
3 participants
@coxipi @Zeitsperre @aulemahal