New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest SBCK, eofs #1328
Use latest SBCK, eofs #1328
Conversation
Marking approved to trigger upstream tests only. |
Everything seems good. Not sure what #egg=blabla in the links is supposed to mean though |
…ofs to base requirements, remove optional handling for eofs, add Eigen3 install documentation, add `sbck` tox flag
More information: https://pip.pypa.io/en/latest/topics/vcs-support/?highlight=egg#git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed for the changes concerning SBCK, but I'm not sure eofs deserves this.
Changes Unknown when pulling efe163d on use_SBCK_master into ** on master**. |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
sbck
git-based install to use their master branch atSBCK-python
sbck
to conda environment.yml (viagit+https
install)sbck
andeofs
astox
modifier flags for easier testingEigen3
core library to CI build for testingsbck
tox builds.Does this PR introduce a breaking change?
No. The package dependencies on typical or upstream installation are unaffected.
Other information:
yrobink/SBCK-python#1
Related? #1204