Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest SBCK, eofs #1328

Merged
merged 15 commits into from Mar 23, 2023
Merged

Use latest SBCK, eofs #1328

merged 15 commits into from Mar 23, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Mar 21, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Sets sbck git-based install to use their master branch at SBCK-python
  • Adds sbck to conda environment.yml (via git+https install)
  • Adds sbck and eofs as tox modifier flags for easier testing
  • Adds step for installing Eigen3 core library to CI build for testing sbck tox builds.
  • Updates installation documentation for clarity.

Does this PR introduce a breaking change?

No. The package dependencies on typical or upstream installation are unaffected.

Other information:

yrobink/SBCK-python#1

Related? #1204

@Zeitsperre Zeitsperre added the standards / conventions Suggestions on ways forward label Mar 21, 2023
@Zeitsperre Zeitsperre added this to the v0.42 milestone Mar 21, 2023
@Zeitsperre Zeitsperre self-assigned this Mar 21, 2023
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Mar 21, 2023
@Zeitsperre Zeitsperre added the approved Approved for additional tests label Mar 21, 2023
@Zeitsperre
Copy link
Collaborator Author

Marking approved to trigger upstream tests only.

@coxipi
Copy link
Contributor

coxipi commented Mar 21, 2023

Everything seems good. Not sure what #egg=blabla in the links is supposed to mean though

…ofs to base requirements, remove optional handling for eofs, add Eigen3 install documentation, add `sbck` tox flag
@github-actions github-actions bot added docs Improvements to documenation sdba Issues concerning the sdba submodule. labels Mar 22, 2023
@Zeitsperre
Copy link
Collaborator Author

Zeitsperre commented Mar 22, 2023

Not sure what #egg=blabla in the links is supposed to mean though

egg= is the original method for specifying the name of a dependency when coming from a VCS system (like git). I just learned today that the newer approach is to use <package_name> @. Will update to see if that works for us (it looks nicer as well).

More information: https://pip.pypa.io/en/latest/topics/vcs-support/?highlight=egg#git

Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed for the changes concerning SBCK, but I'm not sure eofs deserves this.

xclim/sdba/properties.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling efe163d on use_SBCK_master into ** on master**.

@Zeitsperre Zeitsperre merged commit 307cdab into master Mar 23, 2023
13 checks passed
@Zeitsperre Zeitsperre deleted the use_SBCK_master branch March 23, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration docs Improvements to documenation sdba Issues concerning the sdba submodule. standards / conventions Suggestions on ways forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants