Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix correlogram #1336

Merged
merged 2 commits into from Mar 29, 2023
Merged

fix correlogram #1336

merged 2 commits into from Mar 29, 2023

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Mar 27, 2023 •
edited by Zeitsperre

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Function assumed bins=100, it would break if bins was actually something else than the default.

Does this PR introduce a breaking change?

no

Other information:

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Mar 27, 2023
@github-actions github-actions bot added the approved Approved for additional tests label Mar 28, 2023
@juliettelavoie juliettelavoie merged commit 2d68c14 into master Mar 29, 2023
27 checks passed
@juliettelavoie juliettelavoie deleted the fix-correlogram branch March 29, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests sdba Issues concerning the sdba submodule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juliettelavoie @Zeitsperre @aulemahal