Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Data Tagging #1339

Merged
merged 26 commits into from Mar 30, 2023
Merged

Testing Data Tagging #1339

merged 26 commits into from Mar 30, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Mar 29, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adds some checks when running pytest to ensure that xclim-testdata branches used to test against xclim are compatible.
  • Sets the main.yml CI workflow to use tagged commits from xclim-testdata
  • Adds a new CI workflow to check whether the tag found in main.yml is consistent with the latest tag in xclim-testdata, and posts comments and/or fails the build if there is disagreement. This is only triggered if changes are made to main.yml
  • Updates the documentation on how best to update xclim-testdata.

Does this PR introduce a breaking change?

Yes. XCLIM_TESTDATA_BRANCH now points to tagged testing data commits on CI.

Other information:

@Zeitsperre Zeitsperre added the standards / conventions Suggestions on ways forward label Mar 29, 2023
@Zeitsperre Zeitsperre added this to the v0.42 milestone Mar 29, 2023
@Zeitsperre Zeitsperre self-assigned this Mar 29, 2023
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Mar 29, 2023
@Ouranosinc Ouranosinc deleted a comment from github-actions bot Mar 29, 2023
@github-actions
Copy link

github-actions bot commented Mar 29, 2023

Note
It appears that this PR modifies the XCLIM_TESTDATA_BRANCH environment variable to the most recent tag (v0.41.0).

No further action is required.

@Ouranosinc Ouranosinc deleted a comment from github-actions bot Mar 29, 2023
@github-actions github-actions bot added the docs Improvements to documenation label Mar 29, 2023
@Zeitsperre Zeitsperre changed the title [WIP] Testdata Tagging Testing Data Tagging Mar 30, 2023
@Zeitsperre Zeitsperre marked this pull request as ready for review March 30, 2023 15:15
@Zeitsperre Zeitsperre added the priority Immediate priority label Mar 30, 2023
@Zeitsperre Zeitsperre mentioned this pull request Mar 30, 2023
19 tasks
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@github-actions github-actions bot added the approved Approved for additional tests label Mar 30, 2023
@Zeitsperre Zeitsperre merged commit 52ae4b9 into master Mar 30, 2023
14 checks passed
@Zeitsperre Zeitsperre deleted the testdata_tagging branch March 30, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration docs Improvements to documenation priority Immediate priority standards / conventions Suggestions on ways forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants