Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pyOpenSci acceptance badge #1350

Merged
merged 4 commits into from Apr 12, 2023
Merged

Add pyOpenSci acceptance badge #1350

merged 4 commits into from Apr 12, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Apr 12, 2023 •
edited

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adds the pyOpenSci badge to the README
  • Adjusts the example on the README page

Does this PR introduce a breaking change?

No.

Other information:

Congratulations @Ouranosinc/xclim-core !

@Zeitsperre Zeitsperre added standards / conventions Suggestions on ways forward docs Improvements to documenation labels Apr 12, 2023
@Zeitsperre Zeitsperre added this to the v0.43 milestone Apr 12, 2023
@Zeitsperre Zeitsperre requested a review from a team April 12, 2023 19:38
@Zeitsperre Zeitsperre self-assigned this Apr 12, 2023
aulemahal
aulemahal approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@github-actions github-actions bot added the approved Approved for additional tests label Apr 12, 2023
@coveralls
Copy link

Coverage Status

Coverage: 90.651% (-0.01%) from 90.662% when pulling 54fc46c on add_pyopensci into bba33a0 on master.

@Zeitsperre Zeitsperre merged commit 65462ad into master Apr 12, 2023
19 checks passed
@Zeitsperre Zeitsperre deleted the add_pyopensci branch April 12, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests docs Improvements to documenation standards / conventions Suggestions on ways forward
Projects
None yet
Milestone
v0.43
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zeitsperre @coveralls @aulemahal