Add test_timeseries #1356
Merged
Add test_timeseries #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
aulemahal
reviewed
May 2, 2023
Zeitsperre
reviewed
May 3, 2023
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Zeitsperre
approved these changes
May 3, 2023
The initial goal of this PR was to create something that xscen could use for tests. It was not my plan to replace existing fixtures, but I/we can do it if it's something that people want/need. |
|
Well, how about we get the ball rolling here and see how far we get? I'll start with the |
|
what about just having the |
|
@aulemahal Just mentioned that as a much nicer approach to me. Let's go with that. I can effect that changes. |
|
This PR has the @RondeauG of approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
test_timeseries. The function takes in an array and the name of a variable (not indicator) and creates a DataArray or Dataset ready to be used for tests.Does this PR introduce a breaking change?
no
Other information:
I don't really know how pytest and fixtures work, but I tried something...
I put it in xclim.testing.helpers as discussed in the meetingthursday, but it seems like it is not found as a fixture. If I try to use it in-> this is fixed.test_atmos.py, it fails. If I put it inconftest.py, then I am able to use it intest_atmos.py. Should I move it or do something else to make it accessible ?Should I do something like line 14 of test_sdba/conftest.py:
cannon_2015_dist = pytest.fixture(tu.cannon_2015_dist)?