Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore linkcheck #1375

Merged
merged 2 commits into from May 16, 2023
Merged

Ignore linkcheck #1375

merged 2 commits into from May 16, 2023

Conversation

Zeitsperre
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Ignores errors from linkcheck when building the documentation

Does this PR introduce a breaking change?

No.

Other information:

We have a handful of xclim versions that cannot be built on RtD due to changes in the request permissions for bots. This change makes it so that we can still build versions of the documentation even if the linkcheck step fails.

@Zeitsperre Zeitsperre added the bug Something isn't working label May 16, 2023
@Zeitsperre Zeitsperre added this to the v0.44 milestone May 16, 2023
@Zeitsperre Zeitsperre self-assigned this May 16, 2023
@github-actions github-actions bot added CI Automation and Contiunous Integration docs Improvements to documenation labels May 16, 2023
@github-actions github-actions bot added the approved Approved for additional tests label May 16, 2023
@Zeitsperre Zeitsperre merged commit 60f469a into master May 16, 2023
20 checks passed
@Zeitsperre Zeitsperre deleted the ignore_linkcheck branch May 16, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests bug Something isn't working CI Automation and Contiunous Integration docs Improvements to documenation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants