Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error with ttest in change_significance occurring when all inputs are NaNs #1380

Merged
merged 4 commits into from May 29, 2023
Merged

Fix error with ttest in change_significance occurring when all inputs are NaNs #1380

merged 4 commits into from May 29, 2023

Conversation

huard
Copy link
Collaborator

@huard huard commented May 26, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Handles the case where all values are NaNs. This is done anyway for most of the other tests, but a change in Scipy means we have to do this for the ttest as well.

Does this PR introduce a breaking change?

No

Other information:

@huard huard mentioned this pull request May 26, 2023
Open
@huard huard requested a review from aulemahal May 29, 2023 17:31
aulemahal
aulemahal approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sehr gut.

@github-actions github-actions bot added the approved Approved for additional tests label May 29, 2023
@huard
Copy link
Collaborator Author

huard commented May 29, 2023

@tlogan2000 FYI

@huard huard closed this May 29, 2023
@huard huard reopened this May 29, 2023
@huard huard merged commit c91129b into master May 29, 2023
21 of 22 checks passed
@huard huard deleted the fix-1379 branch May 29, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test for change_significance with null array.
2 participants
@huard @aulemahal