Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small clean up of dependencies and environment #1381

Merged
merged 12 commits into from Jun 8, 2023
Merged

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented May 26, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Removes clisops from the environment.yml, which removes the indirect dev dependency to xESMF.
  • While missing around I realized we make an explicit import of filelock, without listing it in the env (it's a dep of tox).
  • statsmodels was in the "dev" deps section, but is a hard dep.
  • On my machine at least, the pin of pylint was blocking the creation of an env with python 3.11. I removed it and it seems to work. I modified the rc file slightly to suppress one warning in the output. And, comble de l'ironie, running pylint in my older env (python 3.10, pylint 2.14) failed... So I leave the study of why it was pinned and if it is safe to unpin it to @Zeitsperre .

Does this PR introduce a breaking change?

No

Other information:

This might be a step towards #1268 !

@aulemahal aulemahal requested a review from Zeitsperre May 26, 2023 21:46
@github-actions github-actions bot added the CI Automation and Contiunous Integration label May 26, 2023
@Zeitsperre
Copy link
Collaborator

I just landed on this post thinking, "will this work, maybe?" tox-dev/sphinx-autodoc-typehints#186 (comment)

It was me. I wrote the post. ...

@Zeitsperre
Copy link
Collaborator

Theory: My workaround to deal with the fact that we can't supply Parameter to a static type definition (by just making it a string) is ignored under Python3.11.

There's a possibility that this could be fixed with the latest sphinx/sphinx-autodoc-typehints, but we can't install it due to limitations with sphinx_rtd_theme (it's effectively unmaintained). Changing to a different theme (like Furo, used in Miranda) involves some changes to our sphinx configuration, but maybe it would be worthwhile investigating soon? This merits its own issue, tbh.

In any case, problems resolved. It had nothing to do with the pylint pin.

@github-actions github-actions bot added the approved Approved for additional tests label Jun 1, 2023
@Zeitsperre
Copy link
Collaborator

Update: The warnings appear to be due to an __annotations__ quirk: https://docs.python.org/3/howto/annotations.html#annotations-quirks

@coveralls
Copy link

Coverage Status

coverage: 90.604%. remained the same when pulling 8a50fb5 on cleanenv-py311 into e7664ee on master.

@Zeitsperre
Copy link
Collaborator

All this needs is an entry under CHANGES.rst and we can merge!

@Zeitsperre Zeitsperre merged commit 510175c into master Jun 8, 2023
13 checks passed
@Zeitsperre Zeitsperre deleted the cleanenv-py311 branch June 8, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xESMF as indirect dependency
3 participants