Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Publishing and better social media publishing #1469

Merged
merged 18 commits into from Sep 28, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Sep 8, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Replaces the token-based authentication for uploads to PyPI/TestPyPI with the Trusted Publishing feature
  • Implement deployment environments as a security measure when running workflows that upload to PyPI/TestPyPI
  • Fixes the Mastodon-publishing action so that excess quotation marks (") are removed
  • Mastodon publishing now uses chuhlomin/render-template to format toots.

Does this PR introduce a breaking change?

Not really. The publishing workflows are no longer dependent on authentication tokens, so these should be removed from the repository secrets and voided.

Other information:

@Zeitsperre Zeitsperre self-assigned this Sep 8, 2023
@Zeitsperre Zeitsperre added standards / conventions Suggestions on ways forward information For development/intsructional purposes labels Sep 8, 2023
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Sep 8, 2023
@Zeitsperre Zeitsperre added this to the v0.46.0 milestone Sep 8, 2023
@github-actions github-actions bot added the docs Improvements to documenation label Sep 15, 2023
@Zeitsperre Zeitsperre changed the title Trusted Publishing Trusted Publishing and better social media publishing Sep 18, 2023
@github-actions github-actions bot removed the information For development/intsructional purposes label Sep 21, 2023
@github-actions github-actions bot added the approved Approved for additional tests label Sep 26, 2023
@Zeitsperre Zeitsperre merged commit 7c2869e into master Sep 28, 2023
16 checks passed
@Zeitsperre Zeitsperre deleted the trusted-publishing branch September 28, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration docs Improvements to documenation standards / conventions Suggestions on ways forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants