Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin cf-xarray for Python3.8 #1519

Merged
merged 2 commits into from Nov 3, 2023
Merged

Pin cf-xarray for Python3.8 #1519

merged 2 commits into from Nov 3, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Nov 3, 2023 •
edited

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Pins cf-xarray below v0.8.5 for Python3.8

Does this PR introduce a breaking change?

No.

Other information:

@Zeitsperre Zeitsperre added priority Immediate priority support Questions and help for users/developers labels Nov 3, 2023
@Zeitsperre Zeitsperre self-assigned this Nov 3, 2023
@coveralls
Copy link

coveralls commented Nov 3, 2023 •
edited

Coverage Status

coverage: 90.559%. first build
when pulling f294d71 on pin-cf_xarray
into ca3caff on master.

aulemahal
aulemahal approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doom clock it ticking for Python 3.8...

@github-actions github-actions bot added the approved Approved for additional tests label Nov 3, 2023
@Zeitsperre Zeitsperre merged commit 55f944c into master Nov 3, 2023
23 checks passed
@Zeitsperre Zeitsperre deleted the pin-cf_xarray branch November 3, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests priority Immediate priority support Questions and help for users/developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zeitsperre @coveralls @aulemahal