reorder with window #1566
Merged
reorder with window #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulemahal
reviewed
Dec 18, 2023
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
coxipi
reviewed
Dec 18, 2023
aulemahal
approved these changes
Feb 19, 2024
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
juliettelavoie
commented
Feb 19, 2024
xclim/sdba/_processing.py
Outdated
| else: | ||
| raise ValueError( | ||
| f"Reordering can only be done along one dimension." | ||
| f" If there is more than one, one of the dimension should be `window`." |
There was a problem hiding this comment.
Suggested change
| f" If there is more than one, one of the dimension should be `window`." | |
| f" If there is more than one, they should be `window` and `time`." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
Previous behavior was to ignored the window (silently) and only do the reorder on the group (eg. dayofyear), now the window is considered.
Other information:
This is for MBCn. In an email, Cannon said: "All parts of the process, including the reordering, are done on your subset, including the buffer around the day of interest. If you’re using 31 days x 30 years then you have 930 data points. Bias adjustment would be performed on these 930 cases. At the end, you’d reorder according to the QDM ranks and select the middle day. Repeat for the remaining days of the year."