Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semver workflow to conform to regex conventions in GitHub #1573

Merged
merged 10 commits into from Jan 9, 2024
Merged

Fix semver workflow to conform to regex conventions in GitHub #1573

merged 10 commits into from Jan 9, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Dec 29, 2023 •
edited

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Bug fix to deal with how regex is handled in GitHub Workflows

Does this PR introduce a breaking change?

No.

Other information:

Worth noting: https://github.com/mpalmer/action-validator

@Zeitsperre Zeitsperre added bug Something isn't working priority Immediate priority labels Dec 29, 2023
@Zeitsperre Zeitsperre added this to the v0.48.0 milestone Dec 29, 2023
@Zeitsperre Zeitsperre self-assigned this Dec 29, 2023
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Dec 29, 2023
@github-actions github-actions bot added information For development/intsructional purposes docs Improvements to documenation labels Dec 29, 2023
@Zeitsperre Zeitsperre requested a review from huard January 8, 2024 16:48
@github-actions github-actions bot added the approved Approved for additional tests label Jan 9, 2024
@coveralls
Copy link

coveralls commented Jan 9, 2024 •
edited

Coverage Status

coverage: 90.294% (-0.01%) from 90.304%
when pulling d184ec8 on semver-take2
into dd9db13 on master.

@Zeitsperre Zeitsperre merged commit c61a29b into master Jan 9, 2024
15 of 16 checks passed
@Zeitsperre Zeitsperre deleted the semver-take2 branch January 9, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huard huard huard approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests bug Something isn't working CI Automation and Contiunous Integration docs Improvements to documenation information For development/intsructional purposes priority Immediate priority
Projects
None yet
Milestone
v0.48.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zeitsperre @coveralls @huard