Sum is a sum #1649
Merged
Sum is a sum #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeitsperre
reviewed
Feb 15, 2024
Zeitsperre
reviewed
Feb 15, 2024
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
|
@Zeitsperre All tests fixed. This is ready to go. It will solve the remaining bug in the rolling statistics PR. |
Zeitsperre
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
to_agg_unitswill not change the units when the aggregation is"sum"."integral"is performed. The output units were previously not reduced, yielding things like "d m s-1".Does this PR introduce a breaking change?
Yes, but
select_resample_opis rarely used by the user directly. And we could consider that this is in fact a fix from a previous ambiguous situation. No internal calls toto_agg_unitswere using"sum".