Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin nbconvert #1658

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Pin nbconvert #1658

merged 2 commits into from
Feb 20, 2024

Conversation

Zeitsperre
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Pins nbconvert to prevent the documentation from failing on build.

Does this PR introduce a breaking change?

No.

Other information:

Example: https://readthedocs.org/projects/xclim/builds/23494704/
jupyter/nbconvert#2092

@Zeitsperre Zeitsperre added bug Something isn't working priority Immediate priority dependencies Pull requests that update a dependency file labels Feb 19, 2024
@Zeitsperre Zeitsperre requested a review from a team February 19, 2024 22:04
@Zeitsperre Zeitsperre self-assigned this Feb 19, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Feb 19, 2024
@coveralls
Copy link

Coverage Status

coverage: 90.18%. remained the same
when pulling 91d4622 on pin-nbconvert
into b7694af on master.

@Zeitsperre Zeitsperre merged commit 826e70e into master Feb 20, 2024
19 checks passed
@Zeitsperre Zeitsperre deleted the pin-nbconvert branch February 20, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests bug Something isn't working dependencies Pull requests that update a dependency file priority Immediate priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zeitsperre @coveralls @aulemahal