Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError when adjusting with preloaded training dataset #1679

Merged
merged 5 commits into from Mar 21, 2024

Conversation

saschahofmann
Copy link
Contributor

@saschahofmann saschahofmann commented Mar 13, 2024

See issue #1678 for an explanation of the problem

Now, returns an empty list if a reduced dimension is not in the dataset chunks in xclim/sdba/base.py map_blocks when checking for badchunks.

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Returns an empty list if a reduced dimension is not in the dataset chunks in xclim/sdba/base.py map_blocks when checking for badchunks

Does this PR introduce a breaking change?

No.

Returns an empty list if a reduced dimension is not in the dataset chunks
Copy link

Welcome, new contributor!

It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the AUTHORS.rst and .zenodo.json:

  • The relevant author information has been added to AUTHORS.rst and .zenodo.json

Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Mar 13, 2024
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Sorry for overlooking that case and thanks for the fix!

@saschahofmann
Copy link
Contributor Author

No problem at all.

Do I need to look into that failing check or is that expected?

@Zeitsperre Zeitsperre added the approved Approved for additional tests label Mar 13, 2024
@Zeitsperre
Copy link
Collaborator

@saschahofmann Don't forget to add your author information as well!

@coveralls
Copy link

coveralls commented Mar 21, 2024

Coverage Status

coverage: 90.196%. remained the same
when pulling 818e743 on saschahofmann:patch-1
into 4ab0cd2 on Ouranosinc:main.

Adding myself to the Author list
@github-actions github-actions bot added the docs Improvements to documenation label Mar 21, 2024
@saschahofmann
Copy link
Contributor Author

Alright if you insist. Also added a comment to the unreleased 0.49.0 bug fixes

@Zeitsperre
Copy link
Collaborator

@saschahofmann You can also add your info to the Zenodo file as well so that you get properly cited when the package is published there. I leave that decision up to you!

@saschahofmann
Copy link
Contributor Author

I'll do that once I make a note worthy contribution 👍😉

@Zeitsperre Zeitsperre merged commit 4cca5f1 into Ouranosinc:main Mar 21, 2024
18 checks passed
@Zeitsperre
Copy link
Collaborator

Thanks @saschahofmann !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests docs Improvements to documenation sdba Issues concerning the sdba submodule.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuantileDeltaMapping adjustment in Dask fails if training dataset has been loaded
4 participants