Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No change is different from negative change #1711

Merged
merged 1 commit into from Apr 17, 2024
Merged

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

In robustness_fractions

  • Computes the fraction of negative change explicitly and returns it
  • The agreement fraction is the maximum of the positive, negative or no change fractions.

Does this PR introduce a breaking change?

Yes, agree_frac has changed. However, it now better reflects its definition and usual expectations. And the case where "no change" is the largest group should not be very frequent, it usually happens with zero-bounded indicators.

Other information:

@aulemahal aulemahal requested a review from huard April 17, 2024 18:27
@aulemahal
Copy link
Collaborator Author

FYI @RondeauG

@github-actions github-actions bot added the approved Approved for additional tests label Apr 17, 2024
@aulemahal aulemahal merged commit 50705ba into main Apr 17, 2024
28 checks passed
@aulemahal aulemahal deleted the fix-robustness-agreefrac branch April 17, 2024 18:59
@coveralls
Copy link

Coverage Status

coverage: 90.192% (+0.002%) from 90.19%
when pulling 0bb653e on fix-robustness-agreefrac
into 2d8726b on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensemble agreement assigns members with exactly no change to the negative fraction
3 participants