Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DMC standalone #1712

Merged
merged 7 commits into from Apr 18, 2024
Merged

Add DMC standalone #1712

merged 7 commits into from Apr 18, 2024

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adds an indicator entry point for computing the duff moisture code (DMC) alone. Alike what is already done for the drought code (DC).
  • I added tests for explicitly testing the two standalone indicators.
  • Minor adjustment for a better error message when passing unneeded parameters to DC and DMC.

Does this PR introduce a breaking change?

No.

Other information:

FYI @raybellwaves

@github-actions github-actions bot added the indicators Climate indices and indicators label Apr 17, 2024
@raybellwaves
Copy link

Thanks!

Zeitsperre
Zeitsperre approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant, clean.

“What is once well done is done forever.” - Henry David Thoreau

xclim/indicators/atmos/_precip.py Show resolved Hide resolved
xclim/indices/fire/_cffwis.py Show resolved Hide resolved
@github-actions github-actions bot added the approved Approved for additional tests label Apr 17, 2024
aulemahal
aulemahal commented Apr 18, 2024
View reviewed changes
xclim/data/fr.json Outdated Show resolved Hide resolved
@Zeitsperre Zeitsperre merged commit b501107 into main Apr 18, 2024
19 checks passed
@Zeitsperre Zeitsperre deleted the add-dmc-standalone branch April 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

@tlogan2000 tlogan2000 Awaiting requested review from tlogan2000

Assignees
No one assigned
Labels
approved Approved for additional tests indicators Climate indices and indicators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duff moisture code
3 participants
@aulemahal @raybellwaves @Zeitsperre