Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust doc in dist_method to explain nnlf is not supported because it reduces dimensions. #1714

Merged
merged 5 commits into from Apr 18, 2024
Merged

Adjust doc in dist_method to explain nnlf is not supported because it reduces dimensions. #1714

merged 5 commits into from Apr 18, 2024

Conversation

huard
Copy link
Collaborator

@huard huard commented Apr 18, 2024 •
edited by Zeitsperre

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adjust doc in dist_method to explain nnlf is not supported because it reduces dimensions

Does this PR introduce a breaking change?

No.

Zeitsperre
Zeitsperre approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Approved for additional tests label Apr 18, 2024
@coveralls
Copy link

Coverage Status

coverage: 90.632% (-0.07%) from 90.703%
when pulling cb4bba9 on fix-1683
into d27b4ed on main.

@Zeitsperre Zeitsperre merged commit 9ff3a9c into main Apr 18, 2024
19 checks passed
@Zeitsperre Zeitsperre deleted the fix-1683 branch April 18, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dist_method does not work for nnlf
3 participants
@huard @coveralls @Zeitsperre