Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in subset, winter_rain_ratio, percentile_doy and heat_wave_total_length #372

Merged
merged 4 commits into from
Feb 19, 2020

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Feb 19, 2020

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes issues discussed internally and brought up by external users on a different platform.
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
  • bumpversion (minor / major / patch) has been called on this branch
  • Tags have been pushed (git push --tags)
  • What kind of change does this PR introduce?
  1. This fixes a bug in subset.wrap_lons_and_split_at_greenwich caused by a typo, that made the tests core dump.
  2. Also, a few fixes for bugs issued by external members:
  • utils.percentile_doy used a panda-like indexing technique that failed with multidimensionnal datasets (not timeseries)
  • Similarly, indices.winter_rain_ratio would also fail with multidim inputs. Fixed it.
  • Finally, heat_wave_total_length was coded in indices and atmos, but wasn't included in the __all__ making it invisible. And there were no tests?? I don't know how that slipped away for so long.
  • Does this PR introduce a breaking change?

Only unbreaking-changes.

@aulemahal aulemahal added the bug Something isn't working label Feb 19, 2020
@aulemahal aulemahal added this to the v0.14 milestone Feb 19, 2020
@aulemahal aulemahal self-assigned this Feb 19, 2020
@coveralls
Copy link

coveralls commented Feb 19, 2020

Pull Request Test Coverage Report for Build 1592

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.043%

Totals Coverage Status
Change from base Build 1586: 0.0%
Covered Lines: 1988
Relevant Lines: 2258

💛 - Coveralls

@huard huard merged commit 5161385 into master Feb 19, 2020
@huard huard deleted the few-fixes branch February 19, 2020 13:35
@davidcaron
Copy link
Contributor

FYI, I ran into the percentile_doy bug in finch, I will base finch on xclim's master for my next tests and probably wait for xclim v0.14 for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants