Fixes in subset, winter_rain_ratio, percentile_doy and heat_wave_total_length #372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
bumpversion (minor / major / patch)
has been called on this branchgit push --tags
)subset.wrap_lons_and_split_at_greenwich
caused by a typo, that made the tests core dump.utils.percentile_doy
used a panda-like indexing technique that failed with multidimensionnal datasets (not timeseries)indices.winter_rain_ratio
would also fail with multidim inputs. Fixed it.heat_wave_total_length
was coded inindices
andatmos
, but wasn't included in the__all__
making it invisible. And there were no tests?? I don't know how that slipped away for so long.Only unbreaking-changes.