Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
bumpversion (minor / major / patch)
has been called on this branchgit push --tags
)What kind of change does this PR introduce?
This pushes the xarray dependency to use the latest version, 0.16. As a consequence it allows to remove the import checks for
xclim.sdba
.Moreover, xarray 0.16 now offers
xr.infer_freq
, portingpd.infer_freq
to cftime indexes, so I modifieddatachecks.check_daily
to use this instead. Also, added a test and test parametrization to test with both cftime and pandas.Does this PR introduce a breaking change?
Yes. Moving to xarray 0.16 might break things. Let's see in the builds!
The History.rst entry for 0.19 has been structured in a clearer way so its easier for user to understand the many breaking changes that release will bring.