Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to and impose latest xarray #504

Merged
merged 7 commits into from Jul 15, 2020
Merged

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
  • bumpversion (minor / major / patch) has been called on this branch
  • Tags have been pushed (git push --tags)
  • What kind of change does this PR introduce?
    This pushes the xarray dependency to use the latest version, 0.16. As a consequence it allows to remove the import checks for xclim.sdba.
    Moreover, xarray 0.16 now offers xr.infer_freq, porting pd.infer_freq to cftime indexes, so I modified datachecks.check_daily to use this instead. Also, added a test and test parametrization to test with both cftime and pandas.

  • Does this PR introduce a breaking change?

Yes. Moving to xarray 0.16 might break things. Let's see in the builds!

  • Other information:

The History.rst entry for 0.19 has been structured in a clearer way so its easier for user to understand the many breaking changes that release will bring.

@aulemahal aulemahal requested a review from huard July 15, 2020 16:19
@aulemahal aulemahal added this to the v0.19 milestone Jul 15, 2020
Copy link
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@coveralls
Copy link

coveralls commented Jul 15, 2020

Pull Request Test Coverage Report for Build 2080

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 91.026%

Totals Coverage Status
Change from base Build 2078: 0.06%
Covered Lines: 3114
Relevant Lines: 3421

💛 - Coveralls

@aulemahal aulemahal merged commit 12ccfa5 into master Jul 15, 2020
@aulemahal aulemahal deleted the adapt-and-impose-xr0.16 branch July 15, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants