Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.bumpversion patch
has been called on this branch.zenodo.json
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
No
Other information:
Coveralls (https://coveralls.io/github/Ouranosinc/xclim) has been adjusted to be a little less discouraging, but a bit more strict (Coveralls will now be a
required
check). PRs now require the following:Failing either of these conditions means the PR will be blocked from merging.
Additionally, Codefactor is now permanently ignoring "Complex Method" (Flake8:
C901
). This isn't great, but we're doing some relatively complex stuff, so let's be easy on ourselves.