Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for latest ouracat #111

Merged
merged 5 commits into from Nov 14, 2022
Merged

Fixes for latest ouracat #111

merged 5 commits into from Nov 14, 2022

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • pre-commit hooks are installed/active in my local clone ($ pre-commit install)
  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • If a merge request has been made in parallel to this PR in xscen-notebooks, it is merged and the submodules have been updated.
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adds "2sem" to the known "frequency" strings. It translates to "2W".
  • Skip unreadable files in parse_directory(according to their permissions).
  • New "_" prefix in patterns of parse_directory, these fields may include underscores and are included in the output.

Does this PR introduce a breaking change?

No.

Other information:

Copy link
Contributor

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aulemahal aulemahal merged commit 659b40a into main Nov 14, 2022
@aulemahal aulemahal deleted the fixes-for-ouracat branch November 14, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants