Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI adjustments #121

Merged
merged 10 commits into from Dec 22, 2022
Merged

UI adjustments #121

merged 10 commits into from Dec 22, 2022

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Nov 29, 2022 •
edited

Pull Request Checklist:

  • pre-commit hooks are installed/active in my local clone ($ pre-commit install)
  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • If a merge request has been made in parallel to this PR in xscen-notebooks, it is merged and the submodules have been updated.
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adds a bit of versatility to the allowed inputs for Data/ProjectCatalogs

Does this PR introduce a breaking change?

No.

Other information:

@Zeitsperre Zeitsperre added the enhancement New feature or request label Nov 29, 2022
@Zeitsperre Zeitsperre self-assigned this Nov 29, 2022
RondeauG
RondeauG approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let you update the History and such, but otherwise it looks good! I also merged the latest 'main' with the new docs.

@Zeitsperre Zeitsperre merged commit b304579 into main Dec 22, 2022
@Zeitsperre Zeitsperre deleted the ui_adjustments branch December 22, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zeitsperre @RondeauG