Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bounds for RotatedPole, Creep fill #174

Merged
merged 4 commits into from Mar 29, 2023
Merged

Create bounds for RotatedPole, Creep fill #174

merged 4 commits into from Mar 29, 2023

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Mar 23, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • This PR does not seem to break the templates.
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Add regrid.create_bounds_rotated_pole. Uses cartopy to get lon_bounds and lat_bounds from the Rotated Pole grid mapping. Unique to that projection, but this covers most cases at Ouranos at least... Still waiting for a proper cf-xarray - cartopy link to implement this upstream. Or to have a brilliant idea and fix the estimation in cf-xarray. In the mean time, this is good enough I think.

    • I added checks in regrid._regrid and spatial_mean so that the conservative-rotated_pole-no_bounds case is covered automatically.
  • Add xs.spatial for spatial tools. Currently only the creep_fill method to fill missing values with the mean of the neighbours. Can also be used for other purposes like making wider land-sea masks.

  • Allow passing GeoDataFrame in spatial_mean's region. This is useful if you want to open a shapefile and subset it before the mean.

Does this PR introduce a breaking change?

No.

Other information:

@aulemahal
Copy link
Collaborator Author

FYI, @mccrayc @marielabonte

Copy link
Contributor

@juliettelavoie juliettelavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add spatial in api.rst to appear in the docs.

@aulemahal aulemahal merged commit 7cf1628 into main Mar 29, 2023
6 checks passed
@aulemahal aulemahal deleted the rotpole-bounds branch March 29, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compute bounds for curvilinear grids
2 participants