New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML notebook #191
YAML notebook #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments.
I think hardcoding a list of functions like that is prone to error, I will push a dynamic option in a few seconds.
I think we also could show an example of CONFIG.set
, to set values in the workflow itself.
And have a word about the "special" auto-configuring sections ? ('logging', 'xclim', 'xarray', 'warning').
Also, here would be a good place for an example using argparse
and passing args to load_config
. I could contribute that part.
for more information, see https://pre-commit.ci
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Would you be able to contribute those? I'm not really familiar with those methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Not sure I get the point of the last cell of the notebook though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve my additions! ;)
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
@parse_config
to a few functions that were missing the wrapper.Does this PR introduce a breaking change?
Other information: