Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use xclim's cftime function #195

Merged
merged 3 commits into from May 4, 2023
Merged

use xclim's cftime function #195

merged 3 commits into from May 4, 2023

Conversation

RondeauG
Copy link
Contributor

@RondeauG RondeauG commented May 4, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • This PR does not seem to break the templates.
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Other information:

cftime.datetime(2000, 1, 1, 0, 0, 0, 0, calendar='noleap', has_year_zero=True) breaks xr.infer_freq.
cftime.DatetimeNoLeap(2000, 1, 1, 0, 0, 0, 0, has_year_zero=True) works.

@RondeauG RondeauG requested a review from aulemahal May 4, 2023 20:02
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

xscen/aggregate.py Outdated Show resolved Hide resolved
@RondeauG RondeauG merged commit 43c4225 into main May 4, 2023
6 checks passed
@RondeauG RondeauG deleted the hotfix-calendar branch May 4, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants