Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python 3.8 support and fix other requirements #199

Merged
merged 8 commits into from May 9, 2023
Merged

Remove Python 3.8 support and fix other requirements #199

merged 8 commits into from May 9, 2023

Conversation

RondeauG
Copy link
Contributor

@RondeauG RondeauG commented May 9, 2023 •
edited

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • This PR does not seem to break the templates.
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Drops support for Python 3.8
  • Unpins xarray's version

Does this PR introduce a breaking change?

xscen no longer support Python 3.8

Other information:

@RondeauG RondeauG requested a review from Zeitsperre May 9, 2023 19:11
@Zeitsperre
Copy link
Contributor

Don't forget to adjust the black and pyupgrade configurations in .pre-commit-config.yaml!

Zeitsperre
Zeitsperre approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RondeauG RondeauG merged commit d769f10 into main May 9, 2023
5 checks passed
@RondeauG RondeauG deleted the abandon38 branch May 9, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pinned xarray to prevent docs from failing Opendap compatibility issues
2 participants
@RondeauG @Zeitsperre