Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_warming_level #210

Merged
merged 16 commits into from Jun 5, 2023
Merged

get_warming_level #210

merged 16 commits into from Jun 5, 2023

Conversation

RondeauG
Copy link
Contributor

@RondeauG RondeauG commented May 31, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • This PR does not seem to break the templates.
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • subset_warming_level got separated in 2: get_warming_level to search in the CSV and subset_warming_level for the subsetting itself. The main difference is that get_warming_level accepts strings or lists of strings, on top of xr.Dataset.

Does this PR introduce a breaking change?

  • Only if someone called subset_warming_level with purely positional arguments. As to not repeat arguments twice, most of them (window, tas_baseline_period, etc.) are now in get_warming_level, while subset_warming_level makes use of kwargs.

Other information:

docs/notebooks/5_warminglevels.ipynb Outdated Show resolved Hide resolved
xscen/extract.py Outdated Show resolved Hide resolved
xscen/extract.py Outdated Show resolved Hide resolved
xscen/extract.py Show resolved Hide resolved
@RondeauG RondeauG merged commit a4c2ffb into main Jun 5, 2023
9 checks passed
@RondeauG RondeauG deleted the warming_lvls branch June 5, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to search within IPCC_annual_global_tas.csv without data
2 participants