Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Updates and modifications to
get_warming_level
:driving_institution
is never needed. If "model" has not matched any column as-is, it tries again withrequested_model.endswith(model)
.Does this PR introduce a breaking change?
Maybe this last point is breaking... If two requested models match to the same column, then the output doesn't have the same length as the input.
Other information:
I think this means we can drop
driving_institution
from the official columns. (We could keep it in our CORDEX catalogs though).