Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce conda failures #288

Merged
merged 3 commits into from Nov 16, 2023
Merged

Reduce conda failures #288

merged 3 commits into from Nov 16, 2023

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Nov 16, 2023 •
edited

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • HISTORY.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Forces the results of pip check for conda builds to always exit 0
  • Uses python -m for calling python commands in workflows

Does this PR introduce a breaking change?

No.

Other information:

The bug causing these failures has been addressed upstream: conda/conda#13258

@github-actions github-actions bot added the CI Modifications to autiomation utilities label Nov 16, 2023
juliettelavoie
juliettelavoie approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@juliettelavoie juliettelavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@Zeitsperre Zeitsperre merged commit fbe82d7 into main Nov 16, 2023
18 checks passed
@Zeitsperre Zeitsperre deleted the reduce-conda-failures branch November 16, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliettelavoie juliettelavoie juliettelavoie approved these changes

Assignees
No one assigned
Labels
CI Modifications to autiomation utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zeitsperre @juliettelavoie