Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for diagnostics #352

Merged
merged 3 commits into from Feb 23, 2024
Merged

add tests for diagnostics #352

merged 3 commits into from Feb 23, 2024

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Feb 22, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Add tests for properties_and_measures, measures_heatmap, measures_improvement, measures_improvement_2d

Does this PR introduce a breaking change?

no

Other information:

Copy link
Contributor

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CHANGES.rst Outdated
@@ -2,6 +2,14 @@
Changelog
=========

v0.9.0 (unreleased)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, it won't be 0.9.0... Maybe put 0.8.3 as a temporary placeholder and we'll change it to the real patch number when we release the patch in a few days.

@juliettelavoie juliettelavoie merged commit a480629 into main Feb 23, 2024
19 checks passed
@juliettelavoie juliettelavoie deleted the add-diag-tests branch February 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants