Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 34 #39

Merged
merged 9 commits into from Aug 9, 2022
Merged

Fix 34 #39

merged 9 commits into from Aug 9, 2022

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Jul 28, 2022

Pull Request Checklist:

  • pre-commit hooks are installed/active in my local clone ($ pre-commit install)
  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • If a merge request has been made in parallel to this PR in xscen-notebooks, it is merged and the submodules have been updated.
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Add argument intermediate_reg_grids to ``xscen.regridding.regrid`. The goal is to regrid in many steps going through intermediate grids before regridding to the final ds_grid. You have to provide the argument for creating the regular grid and the arguments for the regridder for each intermediate step.

EDIT:

*Add argument moving_yearly_window to ``xscen.biasadjust.adjust`. This is necessary for ExtremeValues.

  • Add align_on= 'year' in biasadjust. This is necessary for 360_day calendar. Do we want to make align_on an argument of train and adjust ?
  • Add default coords=None in maybe_unstack_nan

Does this PR introduce a breaking change?

no

Other information:

xscen/regridding.py Outdated Show resolved Hide resolved
xscen/biasadjust.py Outdated Show resolved Hide resolved
xscen/biasadjust.py Show resolved Hide resolved
xscen/regridding.py Outdated Show resolved Hide resolved
xscen/regridding.py Show resolved Hide resolved
xscen/regridding.py Outdated Show resolved Hide resolved
xscen/regridding.py Show resolved Hide resolved
xscen/regridding.py Show resolved Hide resolved
Copy link
Contributor

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@juliettelavoie juliettelavoie merged commit 6ec81ea into main Aug 9, 2022
@juliettelavoie juliettelavoie deleted the fix-34 branch August 9, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify regrid function to allow regridding in many steps
3 participants