Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xr_combine_kwargs in extract_dataset #402

Merged
merged 2 commits into from
May 15, 2024
Merged

Fix xr_combine_kwargs in extract_dataset #402

merged 2 commits into from
May 15, 2024

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented May 15, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

No.

Other information:

Seen by Dominic et Oumou.

@aulemahal aulemahal requested a review from RondeauG May 15, 2024 17:52
@aulemahal aulemahal merged commit b0fcde5 into main May 15, 2024
24 checks passed
@aulemahal aulemahal deleted the fix-extract-ds branch May 15, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants