Fix template + update_attr bug #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulemahal
reviewed
May 15, 2024
| @@ -133,20 +133,23 @@ def update_attr( | |||
| others = others or [] | |||
| # .strip(' .') removes trailing and leading whitespaces and dots | |||
| if attr in ds.attrs: | |||
| others = { | |||
|
|
|||
| others_attrs = { | |||
There was a problem hiding this comment.
Woups, c'était ben niaiseux mon truc. haha
Le code n'a été testé qu'avec des dataset d'une seule variable, je pense que c'est pour ça qu'on a pas vu ça avant.
aulemahal
approved these changes
May 15, 2024
CHANGES.rst
Outdated
| @@ -2,6 +2,15 @@ | |||
| Changelog | |||
| ========= | |||
|
|
|||
| v0.10.0 Unreleased | |||
There was a problem hiding this comment.
Suggested change
| v0.10.0 Unreleased | |
| v0.9.1 (unreleased) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
othersand assign it toothers. This breaks the iteration.othersin l.147, it is no longuer a dict of dataset, we can't get toattrs.Let me know if I misunderstood something.
Does this PR introduce a breaking change?
i don't think so.
Other information: