Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to xscen-509 #51

Merged
merged 12 commits into from Aug 23, 2022
Merged

Adapt to xscen-509 #51

merged 12 commits into from Aug 23, 2022

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Aug 23, 2022

Pull Request Checklist:

  • pre-commit hooks are installed/active in my local clone ($ pre-commit install)
  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • If a merge request has been made in parallel to this PR in xscen-notebooks, it is merged and the submodules have been updated. MR#6
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Use cat: to prefix dataset attributes generated from catalogs.
  • New xscen.utils.get_cat_attrs that outputs a dictionary of those attributes without the prefix.

Does this PR introduce a breaking change?

Yes (but it comes from intake-esm)

Other information:

The intake-esm change also affects how lists are parsed :
https://github.com/intake/intake-esm/blob/ba4bb59ca1174369ff45a09aed030db0a7aa49d2/intake_esm/source.py#L100-L105

I.e.: every object that is iterable (like lists or tuples) is formatted as a comma-separated string. I think this doesn't break xscen, but might be worth noting. The only list-like attribute we usually use is variable.

@aulemahal aulemahal marked this pull request as ready for review August 23, 2022 20:23
Copy link
Contributor

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

HISTORY.rst Show resolved Hide resolved
xscen/utils.py Outdated Show resolved Hide resolved
Co-authored-by: RondeauG <38501935+RondeauG@users.noreply.github.com>
Copy link
Contributor

@juliettelavoie juliettelavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ben beau

@aulemahal
Copy link
Collaborator Author

@Zeitsperre J'ai modifié l'action github pour exclure "docs/notebooks".

@aulemahal aulemahal merged commit 61baccc into main Aug 23, 2022
@aulemahal aulemahal deleted the adapt-to-xscen509 branch August 23, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attributes created by intake-esm contain illegal characters
3 participants