New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to search_data_catalogs #92
Conversation
Question: Should we provide an option to broadcast fixed fields to other members or is that too dangerous? |
I can say that for CORDEX-related datasets, this is how the fixed field data is presented between experiment runs. If you feel it's dangerous, you could add warnings when this is being assumed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few changes I want to make to _dispatch_historical_future
from an issue encountered by Chris. I could do them here, but it can also wait for another PR.
# Conflicts: # HISTORY.rst
Pull Request Checklist:
pre-commit
hooks are installed/active in my local clone ($ pre-commit install
)number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
search_data_catalogs
no longer crashes if it finds nothing. It now returns an empty dictionary and a warning._dispatch_historical_to_future
no longer duplicates fixed fields if they exist in both periods.Does this PR introduce a breaking change?
Other information: