Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak #35

Conversation

leonardo-fernandes
Copy link

Fix memory leak - initially reported in apache#290

Whenever closing an InAppBrowser instance, a webview was left in memory with about:blank page.
This change fixes the issue by destroying and freeing the inAppWebView object.

Platforms affected

  • Android
  • iOS

Motivation and Context

We have detected that a web view is always left open in memory after the InAppBrowser is closed.
apache#290

Description

We have changed the code to destroy the web view.

Testing

The changes were tested with MABS 7.2.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Whenever closing an InAppBrowser instance, a webview was left in memory with about:blank page.
This change fixes the issue by destroying and freeing the inAppWebView object.
@nflsilva nflsilva changed the base branch from outsystems to fix/RMET-1290/prs-external-fixes January 14, 2022 08:41
@nflsilva nflsilva merged commit 8f46c1e into OutSystems:fix/RMET-1290/prs-external-fixes Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants