Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-3712: Dropdown cell change handler returns wrong Id if text is duplicate #382

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

OS-giulianasilva
Copy link
Contributor

@OS-giulianasilva OS-giulianasilva commented Nov 20, 2023

This PR is for fixing the dropdown with duplicated labels returning the wrong ID and not triggering OnCellValueChange

What was happening

  • When the Dropdown has duplicated labels with different values, the OnCellValueChange returns the wrong ID or is not triggered when changing to an option with the same label.

What was done

  • Now, we store the previous cell value into the beginningEdit, to validate if the value was changed into cellEditEnded.

Test Steps

  1. Go to a page with a Grid containing dropdowns with duplicated option's labels
  2. Change to another option with the same label
  3. Check if the OnCellValue Changed was triggered and returns the correct value.

Screenshots

Before:
dropdownDuplicatedLabelsIssue

After:
dropdownDuplicatedLabelsFixed

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@outsystemsbot outsystemsbot bot added the cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR label Nov 20, 2023
rugoncalves
rugoncalves previously approved these changes Nov 22, 2023
Copy link
Contributor

@rugoncalves rugoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @OS-giulianasilva! Just pointed out a small improvement. But that's all

BenOsodrac
BenOsodrac previously approved these changes Nov 22, 2023
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@OS-giulianasilva OS-giulianasilva merged commit e7271d7 into dev Nov 22, 2023
14 checks passed
@OS-giulianasilva OS-giulianasilva deleted the ROU-3712 branch November 22, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants