Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4827: Update Wijmo to version 5.20241.9 #405

Merged
merged 9 commits into from
Mar 27, 2024
Merged

ROU-4827: Update Wijmo to version 5.20241.9 #405

merged 9 commits into from
Mar 27, 2024

Conversation

OS-giulianasilva
Copy link
Contributor

This PR is for updating Wijmo to version 5.20241.9

What was happening

  • The update corrected the following issues:
    • Issue 1: A pencil icon overrides the checkbox when editing a cell in a Grid with RowCheckbox.
    • Issue 2: In a Grid with Dropdown Dependency and duplicated option labels, the dropdown options do not update to the correct ones when the parent is edited.

What was done

  • To fix the second issue, we set the DataMap useFilter property to true and used the getFilteredItems instead of the getDisplayValues to update the DataMap items.

Screenshots

  • Issue 1:
    • Before:
      pencilCheckboxIssue
    • After:
      pencilCheckboxFixed
  • Issue 2:
    • Before:
      DropdownDependencyIssue
    • After:
      DropdownDependencyIssueFixed

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@OS-giulianasilva OS-giulianasilva requested a review from a team as a code owner March 22, 2024 16:21
@outsystemsbot outsystemsbot bot added the cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR label Mar 22, 2024
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@rugoncalves rugoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @OS-giulianasilva!

@OS-giulianasilva OS-giulianasilva merged commit d063c78 into dev Mar 27, 2024
9 of 13 checks passed
@OS-giulianasilva OS-giulianasilva deleted the ROU-4827 branch March 27, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes This code submission conforms with the OutSystems CLA or the CLA is not required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants