ROU-4900: Issue with OnCellClick when reordering columns #416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for fixing the issue with OnCellClick when reordering columns and an issue with the dirty mark.
What was happening
Grid.getColumn()
with the binding as a parameter in the_isDirtyCell()
method, it returned the element corresponding to the associated key. However, when two columns have the same binding, just one of them is mapped to the binding in theAbstractGrid._columns
Map object.What was done
describedById
Wijmo's Column propertydescribedById
to store the Column's uniqueId instead of using the binding or column index.Screenshots
Column reorder issue:
DirtyMark issue:
Checklist