Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-10780: fix Google Maps custom markers with scaled sizes #177

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented Jun 3, 2024

This PR is to fix Google Maps custom markers with scaled sizes.

What was happening

  • Setting custom markers using URL and icon size being set, didn’t have the right behaviour (regression from v1.6.6) and the markers didn't appear properly:

Issue_MapsMarker

What was done

  • The Google Maps marker API on the OutSystems MAps implementation used in the method _setIcon is an object with an attribute size when it should use scaledSize.
  • Also, the Google Maps API got changed and requires the attributes anchor and, for readability (not mandatory in this case), also the origin so the icon gets properly scaled.

Test Steps

  1. Create a test screen with two Maps using custom markers - one setting up the IconSize and the other without this structure filled in
  2. Check that for both Maps we can properly see the Markers we just defined on the low code implementation

Screenshots

image

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@gnbm gnbm added the bug Something isn't working label Jun 3, 2024
@gnbm gnbm requested a review from a team as a code owner June 3, 2024 21:48
@outsystemsbot outsystemsbot bot added the cla:yes label Jun 3, 2024
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@rugoncalves rugoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uuuu, nicely done! 👍

@gnbm gnbm merged commit 811bd67 into dev Jun 4, 2024
14 checks passed
@gnbm gnbm deleted the ROU-10780 branch June 4, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants