Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROU-10685_V2 - [OSMaps] - Leaflet misbehavior when changing marker location after zooming out with more than 2 markers #180

Merged
merged 1 commit into from
Jun 21, 2024
Merged

ROU-10685_V2 - [OSMaps] - Leaflet misbehavior when changing marker location after zooming out with more than 2 markers #180

merged 1 commit into from
Jun 21, 2024

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

What was done

  • Make sure the current center is updated with the right coordinates, when they are calculated by the bounds.

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner June 21, 2024 14:02
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

thetaPC
thetaPC approved these changes Jun 21, 2024
View reviewed changes
Copy link

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no issues found while testing

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 111443c into dev Jun 21, 2024
13 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-10685_V2 branch June 21, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@OS-giulianasilva OS-giulianasilva OS-giulianasilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoaoFerreira-FrontEnd @thetaPC @OS-giulianasilva