Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #33 #34

Merged
merged 7 commits into from Dec 27, 2023
Merged

Fix #33 #34

merged 7 commits into from Dec 27, 2023

Conversation

CodeWithBishal
Copy link
Contributor

@CodeWithBishal CodeWithBishal commented Dec 17, 2023

Fixes #33

Now Fetching the data from firebase realtime database by descending order is possible.

P.S. I have not tested it for all test cases, but it works pretty well for me.

Copy link
Owner

@OutdatedGuy OutdatedGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo @CodeWithBishal, thanks for the PR. Can you revert the version update code? I'll update the version everywhere after merging some more commits.

Ping me after doing it, I'll check the working of code and merge it.

@CodeWithBishal
Copy link
Contributor Author

Done @OutdatedGuy

Copy link
Owner

@OutdatedGuy OutdatedGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi reviewed the PR. It looks good but I have made 2 concerns above. Can you address those?

@OutdatedGuy
Copy link
Owner

OutdatedGuy commented Dec 27, 2023

@CodeWithBishal I have added a commit using proper queries for descending type. Can you confirm if those work properly?

@OutdatedGuy OutdatedGuy self-assigned this Dec 27, 2023
@OutdatedGuy OutdatedGuy added the enhancement New feature or request label Dec 27, 2023
@OutdatedGuy
Copy link
Owner

Looks like it's working fine now. I'll merge this PR now, if you find any problem please open a new issue. Thanks.

Copy link
Owner

@OutdatedGuy OutdatedGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OutdatedGuy OutdatedGuy merged commit d0c7a6c into OutdatedGuy:main Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch Data from Firebase Realtime Database in Descending Order[Feature Request]
2 participants