New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #33 #34
Fix #33 #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yo @CodeWithBishal, thanks for the PR. Can you revert the version update code? I'll update the version everywhere after merging some more commits.
Ping me after doing it, I'll check the working of code and merge it.
Done @OutdatedGuy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi reviewed the PR. It looks good but I have made 2 concerns above. Can you address those?
@CodeWithBishal I have added a commit using proper queries for |
Looks like it's working fine now. I'll merge this PR now, if you find any problem please open a new issue. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #33
Now Fetching the data from firebase realtime database by descending order is possible.
P.S. I have not tested it for all test cases, but it works pretty well for me.