Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Failed to locate ship log fact" spam #586

Closed
2 tasks done
JohnCorby opened this issue May 7, 2023 · 0 comments · Fixed by #576
Closed
2 tasks done

"Failed to locate ship log fact" spam #586

JohnCorby opened this issue May 7, 2023 · 0 comments · Fixed by #576
Assignees
@Bwc9876
Labels
bug Something isn't working fixed in dev Instead of closing issues when you fix them in dev just add this.

Comments

@JohnCorby
Copy link
Member

JohnCorby commented May 7, 2023 •
edited

  • patch SlideCollectionContainer to not do that
  • also fix the __0 thing in ShipLogManager_IsFactRevealed and ShipLogManager_RevealFact
@JohnCorby JohnCorby added the bug Something isn't working label May 7, 2023
@Bwc9876 Bwc9876 mentioned this issue May 7, 2023
Merged
@JohnCorby JohnCorby added the fixed in dev Instead of closing issues when you fix them in dev just add this. label May 7, 2023
JohnCorby added a commit that referenced this issue May 7, 2023
@JohnCorby
1.11.0 (#576)
0e0f345 
## Major features
- Heightmap overhaul!
  - Normal maps (bump maps)
  - Smoothness (gloss) and metallic maps
- Tiling versions of texture/normal/smoothness/metallic maps for finer
up-close detail
- Blend map that uses the red, green, blue, and alpha channels to
control the distribution of 4 tiles respectively, plus a fifth "base"
tile that appears where the others are absent.
  - Stretch has changed to proper unity coordinates, where y is up.

## Minor features
- New `CometTail` module replacing the `hasCometTail` field. Allows
customizing the colour and scale-over-time of a comet tail.

## Improvements
- Patched forget frequency method so it will work for those using it on
custom signals
- Added `teenager` arc type to translator text. This is a mix between
child and adult. It uses the adult mesh but the child texture.
Originally used at the window text on Giant's Deep's statue island.
- Generated textures are now cached. this should reduce memory usage
(resolves #581)
- Textures are named by file path and then the effects applied to them,
for example `[path] > invert > tint [color]`
- Physics details splash in water like the probe and have the probe's
buoyancy.

## Bug fixes
- Fixed NullReferenceException when spawning vessels with physics
- Fixed SpawnDialogue API method always creating a remote trigger
- Physics details are now affected by tornadoes (resolves #580)
- Stretch now behaves more intuitively (does not divide min/max height
by the largest stretch axis) (resolves #551)
- Fix spamming logs with "Fact ID Not Found" on system change (resolves
#586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bwc9876 Bwc9876

Labels
bug Something isn't working fixed in dev Instead of closing issues when you fix them in dev just add this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1.11.0 Outer-Wilds-New-Horizons/new-horizons
2 participants
@Bwc9876 @JohnCorby