Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRE in NHSupernovaPlanetEffectController #737

Closed
xen-42 opened this issue Oct 4, 2023 · 1 comment · Fixed by #742
Closed

NRE in NHSupernovaPlanetEffectController #737

xen-42 opened this issue Oct 4, 2023 · 1 comment · Fixed by #742
Labels
bug Something isn't working fixed in dev Instead of closing issues when you fix them in dev just add this.

Comments

@xen-42
Copy link
Member

xen-42 commented Oct 4, 2023

What Happened?

NullReferenceException: Object reference not set to an instance of an object
Stacktrace: NewHorizons.Components.Props.NHSupernovaPlanetEffectController.Update () (at C:/GitHub/new-horizons/NewHorizons/Components/Props/NHSupernovaPlanetEffectController.cs:228)

What was supposed to happen?

No response

Platform

None

Mods

No response

Logs

No response
@xen-42 xen-42 added the bug Something isn't working label Oct 4, 2023
@JohnCorby
Copy link
Member

line is https://github.com/Outer-Wilds-New-Horizons/new-horizons/blob/main/NewHorizons/Components/Props/NHSupernovaPlanetEffectController.cs#L228

one of the ambient lights is null. potentially destroyed?

@xen-42 xen-42 mentioned this issue Oct 18, 2023
Merged
@xen-42 xen-42 added the fixed in dev Instead of closing issues when you fix them in dev just add this. label Oct 18, 2023
xen-42 added a commit that referenced this issue Oct 18, 2023
@xen-42
1.17.2 (#742)
03af516 
## Bug fixes
- Fix error spam from supernova handling (Fixes #737)
- Fix stock system not being deleted if the user has no DLC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed in dev Instead of closing issues when you fix them in dev just add this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1.17.2 Outer-Wilds-New-Horizons/new-horizons
2 participants
@xen-42 @JohnCorby